Support pool reward tx #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarker
reviewed
Jan 8, 2024
packages/web3/src/utils/exchange.ts
Outdated
| for (const input of tx.unsigned.inputs) { | ||
| try { | ||
| const address = getAddressFromUnlockScript(input.unlockScript) | ||
| inputAddresses.push(address) |
There was a problem hiding this comment.
There might be duplicated addresses in tx inputs
| @@ -24,7 +24,7 @@ import { | |||
| getSenderAddress, | |||
| getALPHDepositInfo, | |||
| isSimpleALPHTransferTx, | |||
| isSimpleTransferTokenTx, | |||
| isSimpleTokenTransferTx, | |||
There was a problem hiding this comment.
How about removing these two isSimple* functions? They are not recommended for exchanges now.
test/exchange.test.ts
Outdated
| @@ -208,8 +208,8 @@ class Exchange { | |||
| async handleBlock(block: node.BlockEntry, resolver: () => void) { | |||
| for (const tx of block.transactions) { | |||
| if (isSimpleALPHTransferTx(tx)) { | |||
| const { targetAddress, depositAmount } = getALPHDepositInfo(tx) | |||
| if (this.hotAddresses.includes(targetAddress)) { | |||
| const infos = getALPHDepositInfo(tx).filter((v) => this.hotAddresses.includes(v.targetAddress)) | |||
There was a problem hiding this comment.
We should replace isSimpleALPHTransferTx with the new validation function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.